Use atof() or strtof()* instead:
printf("float value : %4.8f\n" ,atof(s));
printf("float value : %4.8f\n" ,strtof(s, NULL));
https://cplusplus.com/reference/cstdlib/atof/
https://cplusplus.com/reference/cstdlib/strtof/
atoll()is meant for integers.atof()/strtof()is for floats.
The reason why you only get 4.00 with atoll() is because it stops parsing when it finds the first non-digit.
*Note that strtof() requires C99 or C++11.
Use atof() or strtof()* instead:
printf("float value : %4.8f\n" ,atof(s));
printf("float value : %4.8f\n" ,strtof(s, NULL));
https://cplusplus.com/reference/cstdlib/atof/
https://cplusplus.com/reference/cstdlib/strtof/
atoll()is meant for integers.atof()/strtof()is for floats.
The reason why you only get 4.00 with atoll() is because it stops parsing when it finds the first non-digit.
*Note that strtof() requires C99 or C++11.
Unfortunately, there is no way to do this easily. Every solution has its drawbacks.
Use
atof()orstrtof()directly: this is what most people will tell you to do and it will work most of the time. However, if the program sets a locale or it uses a library that sets the locale (for instance, a graphics library that displays localised menus) and the user has their locale set to a language where the decimal separator is not.(such asfr_FRwhere the separator is,) these functions will stop parsing at the.and you will stil get4.0.Use
atof()orstrtof()but change the locale; it's a matter of callingsetlocale(LC_ALL|~LC_NUMERIC, "");before any call toatof()or the likes. The problem withsetlocaleis that it will be global to the process and you might interfer with the rest of the program. Note that you might query the current locale withsetlocale()and restore it after you're done.Write your own float parsing routine. This might be quite quick if you do not need advanced features such as exponent parsing or hexadecimal floats.
Also, note that the value 4.08 cannot be represented exactly as a float; the actual value you will get is 4.0799999237060546875.
The strtod() function family is what you are looking for.
Not only will strtod() convert the input string to a double (with strtof() for float and strtold() for long double), it also tells you exactly where it stopped parsing the input string (through the second parameter).
Note that it is locale-dependent whether either strtod() or atof() expect a decimal point or a decimal comma...
#include <stdlib.h>
#include <string.h>
#include <math.h>
#include <errno.h>
#include <stdio.h>
int main()
{
// play with "." vs. "," to see why this might be your problem
char * input = "1.45";
// will take a pointer beyond the last character parsed
char * end_ptr;
// strto...() might give an error
errno = 0;
// convert
float result = strtof( input, &end_ptr );
if ( errno == ERANGE )
{
// handle out-of-range error - result will be HUGE_VALF
puts( "out of range" );
}
if ( end_ptr != ( input + strlen( input ) ) )
{
// handle incomplete parse
printf( "Unparsed: '%s'\n", end_ptr );
}
printf( "result: %.2f\n", result );
return 0;
}
Why we shouldn't use atof
On success, atof() function returns the converted floating point number as a double value. If no valid conversion could be performed, the function returns zero (0.0). If the converted value would be out of the range of representable values by a double, it causes undefined behavior.
instead we should use strtod() present in <stdlib.h>
#include<stdio.h>
#include<string.h>
#include<stdlib.h>
int main()
{
char s[] = "1.45";
printf("Float value : %4.2f\n",strtod(s,NULL));
return 0;
}
it will correctly prints 1.45
See the illustration here http://ideone.com/poalgY
I'm supposed to convert a string into a float without using any standard library function, and I can't figure out why this doesn't work.
float strToFloat(const char string[])
{
int i;
int j = 0;
int ten = 1;
float dec = 10;
float result = 0;
for (i = 0; string[i] != '\0'; ++i)
{
if (string[i] == '.')
{
for (; string[i] != '\0'; ++i)
{
dec = (dec * 10) + string[i] - '0';
++j;
}
}
else
result = (result * 10) + string[i] - '0';
}
for (; i != 0; --i)
{
ten *= 10;
}
dec /= ten;
printf("%d", dec);
result += dec;
return result;
}Could someone help me?
Thanks for including a test program - that's always valuable!
However, I'm going to change it, to parse a battery of test cases instead of reading from stdin:
#include <stdio.h>
int main(void)
{
static const char *const strings[] = {
/* these should parse fully */
"12",
"12.0",
"08", /* not octal! */
"+12.34",
".34",
"\t \n2.",
"1e0",
"1e+0",
"1e-0",
"1.e4",
".1e-4",
"-5e006",
"-5e+16",
"-.05",
"-.0",
"-1e6",
/* these should parse only the initial part */
"5c5",
"10ee5",
"0x06", /* not hex! */
"--1" ,
"-+1" ,
"1e--4" ,
"-1e.4",
"1e 4",
"1e-g",
"", "foobar", /* both 0 */
" e5", /* also 0 */
"-1e6",
/* overflow/underflow */
"1e500000",
"1e-500000",
"-1e500000",
"-1e-500000",
};
static const int max = sizeof strings / sizeof strings[0];
for (int i = 0; i < max; ++i)
printf("%20s = > %.9g\n", strings[i], extended_atof(strings[i]));
}
(I changed the function name to extended_atof() so as to be safely distinct from the standard library atof().)
Your implementation passes all these tests. Now we can look at refactoring.
Remove duplication
The things that we parse in multiple places are:
- optional sign
+or- - digit sequences
So perhaps we can refactor each of those into a function? Instead of using an integer index into the supplied string, I prefer to just move the string pointer, and eliminate the need for i:
/* return true for positive, false for negative,
and advance `*s` to next position */
static bool parse_sign(const char **s)
{
switch (**s) {
case '-': ++*s; return false;
case '+': ++*s; return true;
default: return true;
}
}
Let's make use of that in the function:
double extended_atof(const char *s)
{
/*skip white space*/
while (isspace(*s))
++s;
int sign = parse_sign(&s) ? 1 : -1; /*The sign of the number*/
double value = 0.0;
while (isdigit(*s))
value = value * 10.0 + (*s++ - '0');
if (*s == '.') {
++s;
}
double power = 1.0;
while (isdigit(*s)) {
value = value * 10.0 + (*s++ - '0');
power *= 10.0;
}
if (tolower(*s) == 'e') {
++s;
} else {
return sign * value/power;
}
bool powersign = parse_sign(&s); /*The sign following the E*/
int power2 = 0.0; /*The number following the E*/
while (isdigit(*s))
power2 = power2 * 10.0 + (*s++ - '0');
if (powersign) {
while (power2 != 0) {
power /= 10;
--power2;
}
} else {
while (power2 != 0) {
power *= 10;
--power2;
}
}
return sign * value/power;
}
It's slightly shorter, and it still passes all the tests.
Let's see if we can read digit strings in a function, and replace the three places we do that. We'll make it update a count of how many digits wore parsed, so we don't lose leading zeros in the fractional part:
double extended_atof(const char *s)
{
/*skip white space*/
while (isspace(*s))
++s;
int sign = parse_sign(&s) ? 1 : -1; /*The sign of the number*/
double value = parse_digits(&s, NULL);
if (*s == '.') {
++s;
int d; /* digits in fraction */
double fraction = parse_digits(&s, &d);
while (d--)
fraction /= 10.0;
value += fraction;
}
value *= sign;
if (tolower(*s) == 'e') {
++s;
} else {
return value;
}
bool powersign = parse_sign(&s); /*The sign following the E*/
int power2 = parse_digits(&s, NULL); /*The number following the E*/
double power = 1.0;
if (powersign) {
while (power2 != 0) {
power /= 10;
--power2;
}
} else {
while (power2 != 0) {
power *= 10;
--power2;
}
}
return value/power;
}
Tests still pass; what's next?
if (tolower(*s) == 'e') {
++s;
} else {
return value;
}
This can be reversed, and if we're returning, it doesn't matter what we do to s:
if (tolower(*s++) != 'e')
return value;
Here's some near-duplicate blocks:
double power = 1.0;
if (powersign) {
while (power2 != 0) {
power /= 10;
--power2;
}
} else {
while (power2 != 0) {
power *= 10;
--power2;
}
}
Dividing by 10 is the same as multiplying by 0.1, so we can move the test into the loop:
double power = 1.0;
while (power2 != 0) {
power *= powersign ? 0.1 : 10;
--power2;
}
We could go further, and capture powersign ? 0.1 : 10 into a variable. We can also eliminate the power variable from here, and multiply value directly:
const double exponentsign = parse_sign(&s) ? 10. : .1;
int exponent = parse_digits(&s, NULL);
while (exponent--)
value *= exponentsign;
Final version
Here's what I finished up with:
#include <ctype.h>
#include <stdbool.h>
#include <stdlib.h>
/* return true for positive, false for negative,
and advance `*s` to next position */
static bool parse_sign(const char **const s)
{
switch (**s) {
case '-': ++*s; return false;
case '+': ++*s; return true;
default: return true;
}
}
/* return decimal value of digits,
advancing `*s` to the next character,
and storing the number of digits read into *count */
static double parse_digits(const char **const s, int *const count)
{
double value = 0.0;
int c = 0;
while (isdigit(**s)) {
value = value * 10.0 + (*(*s)++ - '0');
++c;
}
if (count)
*count = c;
return value;
}
double extended_atof(const char *s)
{
/*skip white space*/
while (isspace(*s))
++s;
const bool valuesign = parse_sign(&s); /* sign of the number */
double value = parse_digits(&s, NULL);
if (*s == '.') {
int d; /* number of digits in fraction */
++s;
double fraction = parse_digits(&s, &d);
while (d--)
fraction /= 10.0;
value += fraction;
}
if (!valuesign)
value = -value;
if (tolower(*s++) != 'e')
return value;
/* else, we have an exponent; parse its sign and value */
const double exponentsign = parse_sign(&s) ? 10. : .1;
int exponent = parse_digits(&s, NULL);
while (exponent--)
value *= exponentsign;
return value;
}
/* Test program */
#include <stdio.h>
int main(void)
{
static const char *const strings[] = {
/* these should parse fully */
"12",
"12.0",
"08", /* not octal! */
"+12.34",
".34",
"\t \n2.",
"1e0",
"1e+0",
"1e-0",
"1.e4",
".1e-4",
"-5e006",
"-5e+16",
"-.05",
"-.0",
"-1e6",
/* these should parse only the initial part */
"5c5",
"10ee5",
"0x06", /* not hex! */
"--1" ,
"-+1" ,
"1e--4" ,
"-1e.4",
"1e 4",
"1e-g",
"", "foobar", /* both 0 */
" e5", /* also 0 */
"-1e6",
/* overflow/underflow */
"1e500000",
"1e-500000",
"-1e500000",
"-1e-500000",
};
static const int max = sizeof strings / sizeof strings[0];
for (int i = 0; i < max; ++i)
printf("%20s = > %.9g\n", strings[i], extended_atof(strings[i]));
}
There's still an opportunity for a small improvement: an extremely long fractional part could overflow double (this problem existed in your original). Instead of returning a large value from parse_int(), you could consider always returning a fractional value in the range [0...1), and use the number of digits to scale up the integer parts. Then we'd just end up with lost precision at the lower end. That would look like:
static double parse_digits(const char **const s, int *const count)
{
double value = 0.0;
double increment = 0.1;
int c = 0;
while (isdigit(**s)) {
value += increment * (*(*s)++ - '0');
increment /= 10;
++c;
}
if (count)
*count = c;
return value;
}
The corresponding uses would be:
double extended_atof(const char *s)
{
/*skip white space*/
while (isspace(*s))
++s;
int d; /* number of digits */
const bool valuesign = parse_sign(&s); /* sign of the number */
double value = parse_digits(&s, &d);
while (d--)
value *= 10;
if (*s == '.') {
++s;
double fraction = parse_digits(&s, NULL);
value += fraction;
}
if (!valuesign)
value = -value;
if (tolower(*s++) != 'e')
return value;
/* else, we have an exponent; parse its sign and value */
const double exponentsign = parse_sign(&s) ? 10. : .1;
double exponent_f = parse_digits(&s, &d);
while (d--)
exponent_f *= 10;
unsigned long exponent = exponent_f;
while (exponent-->0)
value *= exponentsign;
return value;
}
I think that the worst case of duplication that you need to remove from your code is writing another set of lines for reading the floating number after e (/E).
Even I am just a beginner and doing K&R right now. Here's what I thought when doing the exercise:
For extending the program to handle scientific notations the first thing that I require is to read another floating point number after the character e/E. The code for doing this is already present in the function. Which makes it obvious that we are to reuse that code somehow. I thought that no extra lines of code should should be written for implementing this functionality.
I found that using recursion along with math.h library shortened and simplified the code (particularly the part used for reading the number following e/E) quite considerably.
Here's the code that I wrote:
#include<stdio.h>
#include<ctype.h>
#include<math.h>
#include<string.h>
double atof(char *);
int main(void)
{
char num[20];
scanf("%19s", num);
double number=atof(num);
printf("\n%lf", number);
return 0;
}
double atof(char *num)
{
double val=0.0;
int place=1;
double expo=1.0;
int i=0;
int sign=1;
for(; isspace(num[i]); i++); //skip spaces
sign=(num[i]=='-')?-1:1; //determine sign
if(num[i]=='-'||num[i]=='+')
++i;
while(isdigit(num[i])){ //digits before decimal
val=(val*10)+(num[i]-'0');
++i;
}
if(num[i]=='.') //skip decimal point if present
++i;
while(isdigit(num[i])){ //digits after decimal
val=val*10+(num[i]-'0');
place*=10;
i++;
}
if(num[i]=='e' || num[i]=='E'){ //the extended part for scientific notations
++i;
expo=pow(10,atof(num+i));
}
return (sign*val*expo)/(place);
}
If you can use C99 standard, then the best way is to use snprintf function. On first call you can pass it a zero-length (null) buffer and it will then return the length required to convert the floating-point value into a string. Then allocate the required memory according to what it returned and then convert safely.
This addresses the problem with sprintf that were discussed here.
Example:
Copyint len = snprintf(NULL, 0, "%f", amount);
char *result = malloc(len + 1);
snprintf(result, len + 1, "%f", amount);
// do stuff with result
free(result);
The second parameter is the format string after which the format arguments follow:
Copyfprintf(fPointer, "%f", amount);
%f tells fprintf to write this argument (amount) as string representation of the float value.
A list of possible format specifiers can (for example) be found here.