I'm having difficulties adding TypeScript to an already existing create-react-app application. Previously I've always added it before starting the project, simply by create-react-app my-app --scripts- More on stackoverflow.com

I’ve really enjoyed using vite. I’ve got it setup in a Remix app, which might be more than you want, but it’s been a solid experience More on reddit.com

The best advice I can give is regardless of what you do, maintain the single responsibility principle as best you can. Ie if you have business logic in the code, don’t make a single component/file do one thing if X, something else if Y. If that is the case go up one level and conditionally render. This will keep your code much more readable. More on reddit.com

Senior dev here, I know this might seem long and harsh but what you've built is pretty solid and is overall really well written. Things I would bring up in a code review Stuff like this can be trouble because here you're returning type "movie" | "tv" | undefined and I'm not sure if you're prepared to handle that undefined so forcing yourself to be more explicit is better practice. I'm of the opinion that if you don't have strict mode on, then you're not really using TypeScript. For your Button props you're extending the wrong base. You should extend ButtonHTMLAttributes (ButtonHTMLAttributes comes from React). And type & disabled are already defined in there so you don't need to provide them. The way yours is I don't think will even technically allow you to pass an onClick to your button. Here's how I've coded my most recent custom button component. You might also note that you can't pass className to your inner button element from the outer one. I would recommend you support an override like className={`btn ${props.className ?? ""}`} Imo it's bad practice to take a children that isn't just type of React.ReactNode. If your children is anything else... just make it another prop. And you also have to be very cautious about inlining functional component definitions because this can break the hooks algorithm if you don't render it with JSX. If you're going to do this, you should rename children to be PascalCase (when you destructure it from props), and then call it as to not break the hooks algorithm. And on that note, it's taking in a function without a named argument where it's used... don't do that. Have it take in the argument { movie: ProcessedMovie } not just ProcessedMovie, that way when you pass MovieCard as the children to it here you can just do {MovieCard} because MovieCard is already a function. And on that note is Carousel ever called with anything other than MovieCard? Seems like you should just move MovieCard into the carousel component and call it MovieCardCarousel or just MovieCarousel. It's not like that component is generic at all seeing as it's already taking in movies rather than a generic items list. And if you need a generic carousel... Swiper is basically already providing that to you. EDIT: moved this one to the more important section because I think it is Plain SCSS files can be a bit hazardous as now you've got string references in className props that are hard-reliant on a style that's defined... somewhere. I would definitely say that SCSS modules are worth their pattern. Plus it helps you colocate styles with the rest of your component which is what React is already trying to do with JSX. This is more likely to protect you from forgetting to update the referenced name of your class if you change it in only one place. Things that are just not how I would do it I don't know why you put spaces around variables in interpolated strings. It just makes it look so much wider and imo it's ugly. Same thing with your props propName={ propValue } looks weird to me, no reason it can't be propName={propValue}. Oddly though, I actually like spaces when you're making an object, destructuring an object, or importing so... take that how you will. Maybe just get a linter/prettier to make these stylistic choices for you 🤷‍♂️ Multiple returns are ugly if you can avoid them imo, this function could have been something like this const placeholderImg = "https://www.nadraonline.com/wp-content/uploads/2019/08/nadrablog_placeholder.png"; const generateThumbnail = (thumbnail: string) => !thumbnail ? placeholderImg : POSTER_BASE_URL + thumbnail; I think Redux is overkill more often than it is not. I would heavily recommend Zustand as an alternative in almost any situation. If you have a component which is alone, e.g., button.tsx don't hide it away in src/components/button/button.tsx and then export it from src/components/button/index.ts. Just put it in src/components/button.tsx and then put it somewhere once you have another file associated with it (like tests or SCSS modules). More on reddit.com