Also there is a thing that you might want to notice - it doesn't matter if it is like this
int *p =&matrix1[0][0];
int *q =&matrix2[0][0];
memcpy(p, q, 13*15*sizeof(*p));
Sure you can do this also,
memcpy(&matrix2[0][0], &matrix1[0][0], 13*15*sizeof(matrix1[0][0]));
void *memcpy(void * restrict s1,
const void * restrict s2,
size_t n);
Why this works? Because memcpy function copies n characters from the object pointed to by s2 into the object pointed to by s1. Well this basically sums up every thing you need to use memcpy. So what happens if it is a pointer - the strategy will be same. Pointer point to source and target and they don't overlap - and you then mention the bytes. Voila - it would copy.
Another thing to note - you can get these values 13 and 15 using sizeof operator.
size_t rows = sizeof matrix1 / sizeof matrix1[0];
size_t cols = sizeof matrix1[0] / sizeof matrix1[0][0];
memcpy(&matrix2[0][0], &matrix1[0][0], rows*cols*sizeof(matrix1[0][0]));
And also even more clearly (lurker suggested) :-
memcpy(&matrix2[0][0], &matrix1[0][0], sizeof matrix1);
And these would also work (It was chux who mentioned this)
memcpy(matrix2, matrix1, sizeof matrix2);
Because they all have same value - pointing to same address but their type is different which anyway doesn't matter here because it is converted to void*.
An even better solution which would work whether these variables denotes array or struct or some scalar variable is (suggested by chux )
memcpy(&matrix2, &matrix1, sizeof matrix2);
Answer from user2736738 on Stack OverflowCopy 2D array to another 2D array. - C++ Forum
How to clone multidimensional array to another array Arduino
How to memcpy a part of a two dimensional array in C? - Stack Overflow
c++ - Is copying 2D arrays with "memcpy" technically undefined behaviour? - Stack Overflow
std::memcpy(arr_copy, arr, sizeof arr); (your example) is well-defined.
std::memcpy(arr_copy, arr[0], sizeof arr);, on the other hand, causes undefined behavior (at least in C++; not entirely sure about C).
Multidimensional arrays are 1D arrays of arrays. As far as I know, they don't get much (if any) special treatment compared to true 1D arrays (i.e. arrays with elements of non-array type).
Consider an example with a 1D array:
int a[3] = {1,2,3}, b[3];
std::memcpy(b, a, sizeof(int) * 3);
This is obviously legal.1
Notice that memcpy receives a pointer to the first element of the array, and can access other elements.
The element type doesn't affect the validity of this example. If you use a 2D array, the element type becomes int[N] rather than int, but the validity is not affected.
Now, consider a different example:
int a[2][2] = {{1,2},{3,4}}, b[4];
std::memcpy(b, a[0], sizeof(int) * 4);
// ^~~~
This one causes UB2, because since memcpy is given a pointer to the first element of a[0], it can only access the elements of a[0] (a[0][i]), and not a[j][i].
But, if you want my opinion, this is a "tame" kind of UB, likely to not cause problems in practice (but, as always, UB should be avoided if possible).
1 The C++ standard doesn't explain memcpy, and instead refers to the C standard. The C standard uses somewhat sloppy wording:
C11 (N1570)
[7.24.2.1]/2The
memcpyfunction copiesncharacters from the object pointed to bys2into the object pointed to bys1.
A pointer to the first (or any) element of an array points only to that element, not to the entire array, even though the entire array is reachable through said pointer. Thus, if interpreted literally, it appears that @LanguageLawyer is right: if you give memcpy a pointer to an array element, you're only allowed to copy that single element, and not the successive elements.
This interpretation contradicts the common sense, and most probably wasn't intended.
E.g. consider the example in [basic.types.general]/2, which applies memcpy to an array using a pointer to the first element: (even though examples are non-normative)
constexpr std::size_t N = sizeof(T); char buf[N]; T obj; std::memcpy(buf, &obj, N); std::memcpy(&obj, buf, N);
2 This is moot, because of the problematic wording for memcpy described above.
I'm not entirely sure about C, but for C++, there are strong hints that this is UB.
Firstly, consider a similar example that uses std::copy_n, attempting to perform an element-wise copy rather than a byte-wise one:
#include <algorithm>
consteval void foo()
{
int a[2][2] = {{1,2},{3,4}}, b[2][2] = {{1,2},{3,4}};
std::copy_n(a[0], 4, b[0]);
}
int main() {foo();}
Running functions at compile-time catches most form of UB (it makes the code ill-formed), and indeed compiling this snippet gives:
error: call to consteval function 'foo' is not a constant expression
note: cannot refer to element 4 of array of 2 elements in a constant expression
The situation with memcpy is less certain, because it performs a byte-wise copy. This whole topic seems appears to be vague and underspecified.
Consider the wording for std::launder:
[ptr.launder]/4A byte of storage
bis reachable through a pointer value that points to an objectYif there is an objectZ, pointer-interconvertible withY, such thatbis within the storage occupied byZ, or the immediately-enclosing array object ifZis an array element.
In other words, given a pointer to an array element, all elements of the said array are reachable through that pointer (non-recursively, i.e. through &a[0][0] only a[0][i] are reachable).
Formally, this definition is only used to describe std::launder (the fact that it can't expand the reachable region of the pointer given to it). But the implication seems to be that this definition summarizes reachability rules described by other parts of the standard ([static.cast]/13, notice that reinterpret_cast is defined through the same wording; also [basic.compound]/4).
It's not entirely clear if said rules apply to memcpy, but they should. Because otherwise, the programmer would be able to disregard reachability using library functions, which would make the concept of reachability mostly useless.
It's well-defined, even if you use memcpy(arr_cpy, arr, size) rather than
memcpy(&arr_cpy, &arr, size) (which @LanguageLawyer has finally explained is what they've been arguing for the whole time), for reasons explained by @HolyBlackCat and others.
The intended meaning of the standard is clear, and any language to the contrary is a defect in the standard, not something compiler devs are going to use to pull the rug out from under countless normal uses of memcpy (including 1D arrays) that don't cast int* to int (*)[N], especially since ISO C++ doesn't allow variable-length arrays.
Experimental evidence for how compiler-developers chose to interpret the standard as letting memcpy read from the whole outer object (array-of-array-of-int) which is pointed-to by the void* arg, even if that void* was obtained as a pointer to the first element (i.e. to the first array-of-int):
If you pass a size that's too large, you do get a warning, and for GCC the warning even spells out exactly what object and what size it sees being memcpyed:
#include <cstring>
int dst[2][2];
void foo(){
int arr[2][2] = {{1,1},{1,1}};
std::memcpy(dst, arr, sizeof(arr)); // compiles cleanly
}
void size_too_large(){
int arr[2][2] = {{1,1},{1,1}};
std::memcpy(dst, arr, sizeof(arr)+4);
}
Using &dst, &src makes no difference here to warnings or lack thereof.
Godbolt compiler explorer for GCC and clang -O2 -Wall -Wextra -pedantic -fsanitize=undefined, and MSVC -Wall.
GCC's warning for size_too_large() is:
warning: 'void* memcpy(void*, const void*, size_t)' forming offset [16, 19] is \
out of the bounds [0, 16] of object 'dst' with type 'int [2][2]' [-Warray-bounds]
11 | std::memcpy(dst, arr, sizeof(arr)+4);
| ~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~
<source>:3:5: note: 'dst' declared here
3 | int dst[2][2];
clang's doesn't spell out the object type, but does still show sizes:
<source>:11:5: warning: 'memcpy' will always overflow; destination buffer has size 16, but size argument is 20 [-Wfortify-source]
std::memcpy(dst, arr, sizeof(arr)+4);
^
So it's clearly safe in practice with real compilers, a fact which we already knew. Both see the destination arg as being the whole 16-byte int [2][2] object.
However, GCC and clang are possibly less strict than the ISO C++ standard. Even with dst[0] as the destination (decaying to an int* rather than int (*)[2]), they both still report the destination size as 16 bytes with type int [2][2].
HolyBlackCat's answer points out that calling memcpy this way really only gives it the 2-element sub-array, not the whole 2D array, but compilers don't try to stop you from or warn about using a pointer to the first element to access any part of a larger object.
As I said, testing real compilers can only show us that this is well-defined on them currently; arguments about what they might do in future requires other reasoning (based on nobody wanting to break normal uses of memcpy, and the standard's intended meaning.)
ISO standard's exact wording: arguably a defect
The only question is whether there's any merit to the argument that there's a defect in the standard's wording for the way it explains which object is relevant for the language beyond the end of an object, whether that's limited to the single pointed-to object after array to pointer "decay" for passing an arg to memcpy. (And yes, that would be a defect in the standard; it's widely assumed that you don't need and shouldn't use &arr with an array type for memcpy, or basically ever AFAIK.)
To me, that sounds like a misinterpretation of the standard, but I may be biased because I of course want to read it as saying what we all know is true in practice. I still think that having it be well-defined is a valid interpretation of the wording in the standard, but the other interpretation may also be valid. (i.e. it could be ambiguous whether it's UB or not, which would be a defect.)
A void* pointing to the first element of an array can be cast back to an int (*)[2] to access the whole array object. That isn't how memcpy uses it, but it shows that the pointer hasn't lost its status as a pointer to the whole N-dimensional array. I think the authors of the standard are assuming this reasoning, that this void* can be considered a pointer to the whole object, not just the first element.
However, it's true that there's special language for how memcpy works, and a formal reading could argue that this doesn't let you rely on normal C assumptions about how memory works.
But the UB interpretation allowed by the standard is not how anyone wants it to work or thinks it should. And it would apply to 1D arrays, so this interpretation conflicts with standard examples of using memcpy that are well-known / universally assumed to work. So any argument that the wording in the standard doesn't quite match this is an argument that there's a defect in the wording, not that we need to change our code and avoid this.
There's also no motivation for compiler devs to try to declare this UB because there's very little optimization to be had here (unlike with signed overflow, type-based aliasing, or assumption of no NULL deref).
A compiler assuming that runtime-variable size must only affect at most the whole first element for the pointer type that got cast to void* wouldn't allow much optimization in real code. It's rare for later code to only access elements strictly after the first, which would let the compiler do constant-propagation or similar things past a memcpy that was intended to write it.
(As I said, everyone knows this isn't what the standard intended, unlike with clear statements about signed overflow being UB.)
For example if I have array data int x[3] ={4,5,6}; and another int y[8] = {1,2,3,0,0,0,7,8}; can I copy array data x onto array data y and the start location is y[3] with ending location y[5].
I think that what you want to do in fun is:
for(int j = 0; j < YDIM; j++)
{
for(int i = 0; i < XDIM; i++)
{
array[j][i] = tmp[j][i];
}
}
You cannot use a single memcpy because your array is not a contiguous bloc of memory; it is a jagged array (each 1-dimensional block is stored in a separate allocation).
I'm assuming you have your dimensions in the right order (you didn't post the body of allocate3d so that can't be verified)
I'm not sure you need a temp array there. Since you're already passing in the array itself, and in c you can modify arrays directly with other functions. Maybe...
void fun(double **array, int XDIM, int YDIM)
{
for(int j = 0; j < YDIM; j++)
{
for(int i = 0; i < XDIM; i++)
{
array[j][i] = 2.5;
}
}
}
Let me know how it goes!
Well, 2D array element's are stored in memory in a row, |x| == memory cell
1.row |x|x|x|x|x|x| 2.row |x|x|x|x|x|x| 3.row |x|x|x|x|x|x|
while every pointer of array of pointer can point on completely different address in memory. For example first pointer points on array on adress 100, second points on adress 248, third on array on adress 2.
3.row |x|x|x|x|x|x| |?|?|?| 1.row |x|x|x|x|x|x| |?|?|?|?| 2.row |x|x|x|x|x|x|
So you could use memcpy on every row of arrays separately, or copy them element by element.
Hope it helps.
There are 2 problems with your memcpy:
1. src rows are not necessarily continuous
Consider:
#define x 2
float src_row_0[x] = { 0.0f, 0.1f };
float src_row_1[x] = { 1.0f, 1.1f };
float * src_rows[x] = { src_row_0, src_row_1 };
float ** src = src_rows;
There is no guarantee that rows are next to each other in memory. So you cannot copy bytes with single memcpy. Same applies even if you allocated srcrows with malloc.
You'll need to copy each row separately.
2. Size x is not enough to copy all bytes
memcpy copies number of bytes, not number of elements. Single float variable is usually more than 1 byte in size. Simply passing x to memcpy is not enough. You'll need to multiply each number of items by size of an single element.
Fixing the copy
Corrected copy would look something like this:
for(int i=0; i<x; ++i) {
memcpy(&dst[i], src[i], x * sizeof(float));
}
Example on Ideone.
You could use memcpy.
If the multidimensional array size is given at compile time, i.e mytype myarray[1][2], then only a single memcpy call is needed
memcpy(dest, src, sizeof (mytype) * rows * columns);
If, like you indicated the array is dynamically allocated, you will need to know the size of both of the dimensions as when dynamically allocated, the memory used in the array won't be in a contiguous location, which means that memcpy will have to be used multiple times.
Given a 2d array, the method to copy it would be as follows:
char** src;
char** dest;
int length = someFunctionThatFillsTmp(src);
dest = malloc(length*sizeof(char*));
for ( int i = 0; i < length; ++i ){
//width must be known (see below)
dest[i] = malloc(width);
memcpy(dest[i], src[i], width);
}
Given that from your question it looks like you are dealing with an array of strings, you could use strlen to find the length of the string (It must be null terminated).
In which case the loop would become
for ( int i = 0; i < length; ++i ){
int width = strlen(src[i]) + 1;
dest[i] = malloc(width);
memcpy(dest[i], src[i], width);
}
When you have a pointer to a pointer in C, you have to know how the data is going to be used and laid out in the memory. Now, the first point is obvious, and true for any variable in general: if you don't know how some variable is going to be used in a program, why have it? :-). The second point is more interesting.
At the most basic level, a pointer to type T points to one object of type T. For example:
int i = 42;
int *pi = &i;
Now, pi points to one int. If you wish, you can make a pointer point to the first of many such objects:
int arr[10];
int *pa = arr;
int *pb = malloc(10 * sizeof *pb);
pa now points to the first of a sequence of 10 (contiguous) int values, and assuming that malloc() succeeds, pb points to the first of another set of 10 (again, contiguous) ints.
The same applies if you have a pointer to a pointer:
int **ppa = malloc(10 * sizeof *ppa);
Assuming that malloc() succeeds, now you have ppa pointing to the first of a sequence of 10 contiguous int * values.
So, when you do:
char **tmp = malloc(sizeof(char *)*CR_MULTIBULK_SIZE);
tmp points to the first char * object in a sequence of CR_MULTIBULK_SIZE such objects. Each of the pointers above is not initialized, so tmp[0] to tmp[CR_MULTIBULK_SIZE-1] all contain garbage. One way to initialize them would be to malloc() them:
size_t i;
for (i=0; i < CR_MULTIBULK_SIZE; ++i)
tmp[i] = malloc(...);
The ... above is the size of the ith data we want. It could be a constant, or it could be a variable, depending upon i, or the phase of the moon, or a random number, or anything else. The main point to note is that you have CR_MULTIBULK_SIZE calls to malloc() in the loop, and that while each malloc() is going to return you a contiguous block of memory, the contiguity is not guaranteed across malloc() calls. In other words, the second malloc() call is not guaranteed to return a pointer that starts right where the previous malloc()'s data ended.
To make things more concrete, let's assume CR_MULTIBULK_SIZE is 3. In pictures, your data might look like this:
+------+ +---+---+
tmp: | |--------+ +----->| a | 0 |
+------+ | | +---+---+
| |
| |
| +------+------+------+
+-------->| 0 | 1 | 2 |
+------+------+------+
| |
| | +---+---+---+---+---+
| +--->| t | e | s | t | 0 |
+------+ +---+---+---+---+---+
|
|
| +---+---+---+
+--->| h | i | 0 |
+---+---+---+
tmp points to a contiguous block of 3 char * values. The first of the pointers, tmp[0], points to a contiguous block of 3 char values. Similarly, tmp[1] and tmp[2] point to 5 and 2 chars respectively. But the memory pointed to by tmp[0] to tmp[2] is not contiguous as a whole.
Since memcpy() copies contiguous memory, what you want to do can't be done by one memcpy(). Further, you need to know how each tmp[i] was allocated. So, in general, what you want to do needs a loop:
char **realDest = malloc(CR_MULTIBULK_SIZE * sizeof *realDest);
/* assume malloc succeeded */
size_t i;
for (i=0; i < CR_MULTIBULK_SIZE; ++i) {
realDest[i] = malloc(size * sizeof *realDest[i]);
/* again, no error checking */
memcpy(realDest[i], tmp[i], size);
}
As above, you can call memcpy() inside the loop, so you don't need nested loop in your code. (Most likely memcpy() is implemented with a loop, so the effect is as if you had nested loops.)
Now, if you had code like:
char *s = malloc(size * CR_MULTIBULK_SIZE * sizeof *s);
size_t i;
for (i=0; i < CR_MULTIBULK_SIZE; ++i)
tmp[i] = s + i*CR_MULTIBULK_SIZE;
I.e., you allocated contiguous space for all the pointers in one malloc() call, then you can copy all the data without a loop in your code:
size_t i;
char **realDest = malloc(CR_MULTIBULK_SIZE * sizeof *realDest);
*realDest = malloc(size * CR_MULTIBULK_SIZE * sizeof **realDest);
memcpy(*realDest, tmp[0], size*CR_MULTIBULK_SIZE);
/* Now set realDest[1]...realDest[CR_MULTIBULK_SIZE-1] to "proper" values */
for (i=1; i < CR_MULTIBULK_SIZE; ++i)
realDest[i] = realDest[0] + i * CR_MULTIBULK_SIZE;
From the above, the simple answer is, if you had more than one malloc() to allocate memory for tmp[i], then you will need a loop to copy all the data.